Move battery options to non-asus specific folder #965
Conversation
fidgetingbits
force-pushed
the
make-battery-common
branch
from
e8f916c
to
9c4a5c3
Compare
|
Let me know when you have tested this: Currently we have an eval error for some laptops. |
|
I'm curious why one would want to use this instead of the more full-featured |
|
It's a good question. I was also recently pondering if just adding some module options for tlp package would be better. I wasn't actually aware of tlp until this PR. Originally the main appeal of the nixos-hardware options was I could easily set them without having to look into how to configure anything and then just wanted it on my other non asus laptop. Is there any particular reason similar tunable options haven't been added to the tlp package? |
|
I was thinking the same. I don't think tlp is a particular big dependency either. Only thing is that it might conflict with power-profile-daemon which is in use, when you use most desktop environments. |
Description of changes
The current
asus/battery.nixfile isn't actually asus-specific, and seems useful to be used by other non-asus laptops. This moves it into a generic foldercommon/pc/laptop/and updates the current users.Since there was also an option
hardware.asus.battery, this deprecates the old option and changes to newhardware.batteryinstead.I tested that the deprecation warning works if
hardware.asus.battery.chargeUpTo = 50;is set somewhere. I also ran the test script against the three updated asus laptops to ensure they pass.I have not actually tested the changes on a live machine.
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input